PI-2472: Refactor AreaWeightedRegridder#3606
PI-2472: Refactor AreaWeightedRegridder#3606abooton merged 11 commits intoSciTools:area_weighted_regriddingfrom
Conversation
|
I managed to reproduce the doctest failure by updating my local conda install to match the environment that Travis uses. I'll continue debugging tomorrow (unless someone else gets to it first!) ;) |
|
The doctest was failing due to the fact that the source cube is now being cached (a new cube is created) in AreaWeightedRegridder. This means that when RectilinearRegridder._create_cube is called, copy_coords, didn't correctly copy the |
|
|
… be regridded are equal to the data dims of the x and y coordinates of the source cube used to set up the regridder
|
Looks good. :) |
* pr/3623: PI-2472: Update area weighted regridder to accept different dim data (SciTools#3625) PI-2472: Fix issue related to comparison / equality in regridding code (SciTools#3624) Remove unused variables in regridding code (SciTools#3620) Add docstring and what's new (SciTools#3619) Move calculation of area weights from perform to prepare (SciTools#3617) PI-2472: Refactor AreaWeightedRegridder (SciTools#3606) Test for AreaWeightedRegridder (SciTools#3604) Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform (SciTools#3601)
* Add prepare and perform to the AreaWeightedRegridder
This pull request refactors
AreaWeightedRegridderto call the relevant__prepareand__performfunctions.I've not come across
mock.sentinelbefore, so I've had to comment out one assert that I can't get to work.